Repository navigation
Support multiple favicons #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deberlhe-jb
wants to merge
4
commits into
brokenhandsio:main
Choose a base branch
from
deberlhe-jb:feat/support-multiple-favicons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #if canImport(FoundationEssentials) | ||
| internal import FoundationEssentials | ||
| #else | ||
| internal import Foundation | ||
| #endif | ||
|
|
||
| /// Paths (relative to the content directory's assets) to a logo image. | ||
| public struct FavIcon: Sendable | ||
| { | ||
| public var type: FavIconType | ||
| public var path: String | ||
|
|
||
| public init( | ||
| type: FavIconType = .svg, | ||
| path: String? = nil | ||
| ) { | ||
| self.type = type | ||
| self.path = path ?? type.defaultPath() | ||
| } | ||
|
|
||
| @available(*, deprecated, message: "This initializer guesses the type from a string and is therefore not as reliable as init(type:path:).") | ||
| public init(path: String) { | ||
| self.path = path | ||
| self.type = FavIconType.guessFrom(file: path) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| #if canImport(FoundationEssentials) | ||
| internal import FoundationEssentials | ||
| #else | ||
| internal import Foundation | ||
| #endif | ||
|
|
||
| public enum FavIconType: Sendable, Equatable { | ||
| case svg | ||
| case png(PNGSize) | ||
| case ico | ||
|
|
||
| public enum PNGSize: Int, Sendable { | ||
| case xUnknown = 0 | ||
| case x16 = 16 | ||
| case x32 = 32 | ||
| case x180 = 180 | ||
| } | ||
|
|
||
| public func ext() -> String { | ||
| switch self { | ||
| case .svg: return "svg" | ||
| case .png: return "png" | ||
| case .ico: return "ico" | ||
| } | ||
| } | ||
|
|
||
| public func defaultPath() -> String { | ||
| switch self { | ||
| case .svg: return "assets/favicon.svg" | ||
| case .png(let size): return "assets/favicon-\(size.rawValue).png" | ||
| case .ico: return "assets/favicon.ico" | ||
| } | ||
| } | ||
|
|
||
| public func rel() -> String { | ||
| switch self { | ||
| case .png(.x180): return "apple-touch-icon" | ||
| case .svg, .ico, .png: return "icon" | ||
| } | ||
| } | ||
|
|
||
| public func sizes() -> String? { | ||
| switch self { | ||
| case .svg, .ico: return "any" | ||
| case .png(.xUnknown): return nil | ||
| case .png(let size): return "\(size.rawValue)x\(size.rawValue)" | ||
| } | ||
| } | ||
|
|
||
| public func mimeType() -> String? { | ||
| switch self { | ||
| case .svg: return "image/svg+xml" | ||
| case .png(.x180), .ico: return nil | ||
| case .png: return "image/png" | ||
| } | ||
| } | ||
|
|
||
| public static func guessFrom(file name: String) -> Self { | ||
| let ext = name.components(separatedBy: ".").last?.lowercased() | ||
|
|
||
| switch ext { | ||
| case "svg": return .svg | ||
| case "ico": return .ico | ||
| default: return .png(.xUnknown) | ||
| } | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xTim I'm not sure wether I should add the
@_disfavoredOverloadannotation here since it would pick SVG as the default format instead of guessing a possibly more appropriate one. What do you think ?