Repository navigation
fix: recheck queue state before emitting deferred drain - #2086
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing an empty array schedules a
drainevent. If actual work is added before that event runs, the scheduled callback still fires andawait q.drain()resolves while tasks are pending.Recheck
q.idle()inside the deferred callback. Add regression tests forpush,unshift,pushAsync, andunshiftAsync, each followed by real work before the scheduled drain runs. This reproduces the behavior reported in #1729 without mixing async workers and callbacks.Validation on Node.js 24.19.0: all four new tests fail before the fix; all 694 Node tests pass afterward. ESLint passes for both changed files.