Repository navigation
Conversation
pralav-25
marked this pull request as draft
October 2, 2026 07:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
auto({})without a callback returnsundefined, even though the documented Promise API and nonempty task graphs return a Promise. This makes.then()fail when an application's task graph happens to be empty.autoInject({})inherits the same behavior.Resolve the existing promise callback and return its Promise in the empty-task branch. Callback calls still run synchronously with the same arguments and return value. Add regressions for
auto({}),auto({}, 2), andautoInject({})that call.then()and verify the resolved result.Validation: all three regressions fail before the fix; all 706 Node tests and repository-wide ESLint pass afterward.
git diff --checkpasses. Browser tests were not run locally.Assisted by OpenAI Codex; the fix was reviewed and the regression and full Node suite were run locally.