Repository navigation
[Yamaha TG33] New adaptation for TG33 voices #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
d1aeba6
f5b1125
9c774b5
b23284d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| # | ||
| # Yamaha TG33 adaptation, contributed to KnobKraft Orm under its dual licensing | ||
| # (Affero GPL by default, an MIT license is available for purchase from Christof Ruch). | ||
| # | ||
| # Voices, through the edit buffer. The SysEx follows Sean Luke's Edisyn TG33/SY22/SY35 editor | ||
| # (https://github.com/eclab/edisyn, edisyn/synth/yamahatg33, Apache 2.0): | ||
| # - the current voice is requested with F0 43 2n 7E "LM 0012VE" F7, n the device number; | ||
| # - it comes back as one message, F0 43 0n 7E <count MSB> <count LSB> "LM 0012VE" <587 bytes> <checksum> F7, | ||
| # 605 bytes in all; the voice name is 8 ASCII characters at byte 28; | ||
| # - the checksum covers "LM 0012VE" and the voice data; | ||
| # - sent back in the same form, it replaces the voice being edited. | ||
| # The TG33 has no request for a stored voice: Edisyn selects it with a program change first. | ||
| # The SY22 and SY35 use another format ("PK 2203AE", 592 bytes) and are not covered here. | ||
| # | ||
| from typing import List | ||
|
|
||
| import testing | ||
|
|
||
| _header = [0x4C, 0x4D, 0x20, 0x20, 0x30, 0x30, 0x31, 0x32, 0x56, 0x45] # "LM 0012VE" | ||
| _voice_length = 605 | ||
| _name_start = 28 | ||
| _name_length = 8 | ||
|
|
||
|
|
||
| def name(): | ||
| return "Yamaha TG33" | ||
|
|
||
|
|
||
| def createDeviceDetectMessage(channel): | ||
| return createEditBufferRequest(channel) | ||
|
|
||
|
|
||
| def needsChannelSpecificDetection(): | ||
| return True | ||
|
|
||
|
|
||
| def deviceDetectWaitMilliseconds(): | ||
| return 300 | ||
|
|
||
|
|
||
| def channelIfValidDeviceResponse(message): | ||
| if isEditBufferDump(message): | ||
| return message[2] & 0x0F | ||
| return -1 | ||
|
|
||
|
|
||
| def createEditBufferRequest(channel): | ||
| return [0xF0, 0x43, 0x20 | (channel & 0x0F), 0x7E] + _header + [0xF7] | ||
|
|
||
|
|
||
| def isEditBufferDump(message): | ||
| return (len(message) == _voice_length | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| and message[0] == 0xF0 | ||
| and message[1] == 0x43 | ||
| and message[2] & 0xF0 == 0x00 | ||
| and message[3] == 0x7E | ||
| and message[6:16] == _header | ||
| and message[-1] == 0xF7 | ||
| and checksum(message[6:-2]) == message[-2]) | ||
|
|
||
|
|
||
| def numberOfBanks(): | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we give internal-bank retrieval an explicit selection sequence? With the edit-buffer API used here, the host downloads a bank by sending Program Change followed by the current-voice request. It doesn't select Internal first, so if the TG33 is currently on a preset or card bank, the download can collect voices from that bank while presenting them as the internal bank. Edisyn's changePatch() looks like a useful guide: it sends the VOICE-button SysEx to leave Edit mode, waits, sends CC0=0 and CC32 for the desired bank, then Program Change, with another wait before requesting the voice. It might be worth implementing a numbered request path that includes those steps, with a mock test for the outgoing sequence. Simply adding a custom program-change hook wouldn't cover this host download path. Reference: https://github.com/eclab/edisyn/blob/master/edisyn/synth/yamahatg33/YamahaTG33.java |
||
| return 1 | ||
|
|
||
|
|
||
| def numberOfPatchesPerBank(): | ||
| return 64 | ||
|
|
||
|
|
||
| def convertToEditBuffer(channel, message): | ||
| if isEditBufferDump(message): | ||
| return message[0:2] + [channel & 0x0F] + message[3:] | ||
|
christofmuc marked this conversation as resolved.
Resolved
|
||
| raise Exception("This is not a Yamaha TG33 voice") | ||
|
|
||
|
|
||
| def nameFromDump(message): | ||
| if isEditBufferDump(message): | ||
| return ''.join(chr(x) if 32 <= x < 127 else ' ' for x in message[_name_start:_name_start + _name_length]) | ||
| return "Invalid" | ||
|
|
||
|
|
||
| def renamePatch(message, new_name): | ||
|
christofmuc marked this conversation as resolved.
Resolved
|
||
| if isEditBufferDump(message): | ||
| name = [ord(c) if 32 <= ord(c) < 127 else 0x20 for c in new_name[:_name_length].ljust(_name_length)] | ||
| result = message[:_name_start] + name + message[_name_start + _name_length:] | ||
| result[-2] = checksum(result[6:-2]) | ||
| return result | ||
| raise Exception("Can only rename Yamaha TG33 voices") | ||
|
|
||
|
|
||
| def checksum(data): | ||
| return -sum(data) & 0x7F | ||
|
|
||
|
|
||
| def make_test_data(): | ||
| def edit_buffers(data: testing.TestData) -> List[testing.ProgramTestData]: | ||
| # Edisyn's initial TG33 voice (edisyn/synth/yamahatg33/YamahaTG33.init, Apache 2.0) | ||
| voice = data.all_messages[0] | ||
| assert checksum(voice[6:-2]) == voice[-2] | ||
| assert createEditBufferRequest(2) == [0xF0, 0x43, 0x22, 0x7E] + _header + [0xF7] | ||
| assert channelIfValidDeviceResponse(convertToEditBuffer(5, voice)) == 5 | ||
| damaged = voice.copy() | ||
| damaged[100] ^= 0x01 | ||
| assert not isEditBufferDump(damaged), "a voice damaged in transfer is refused" | ||
| yield testing.ProgramTestData(message=voice, name="Untitled", rename_name="Vector 1") | ||
|
|
||
| return testing.TestData(sysex=R"testData/Yamaha_TG33/edisyn-init-voice.syx", edit_buffer_generator=edit_buffers) | ||
Uh oh!
There was an error while loading. Please reload this page.