Repository navigation
[core] Pin pip and virtualenv exactly in the Dockerfiles - #4390
Merged
Merged
Conversation
The Dockerfiles installed pip and virtualenv with lower bounds
("pip>=26.2.2", "virtualenv>=21.14.12"). A lower bound lets every image
build pick up whatever is newest, so builds are not reproducible and a
new pip or virtualenv release can break them without any change here.
Pin them exactly instead, to the versions the Makefile already uses:
pip 26.2.2 (desktop/core/pip-bootstrap-requirements.txt) and virtualenv
21.14.13 (VIRTUAL_ENV_VERSION in Makefile.vars). Both are at or above
the minimum fixed releases for the eMudhra CA incident. Add comments to
keep the pins in sync.
|
|
UI Code Coverage Report
|
Backend Code Coverage Report •
|
agl29
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfiles installed pip and virtualenv with lower bounds ("pip>=26.2.2", "virtualenv>=21.14.12"). A lower bound lets every image build pick up whatever is newest, so builds are not reproducible and a new pip or virtualenv release can break them without any change here.
Pin them exactly instead, to the versions the Makefile already uses: pip 26.2.2 (desktop/core/pip-bootstrap-requirements.txt) and virtualenv 21.14.13 (VIRTUAL_ENV_VERSION in Makefile.vars). Both are at or above the minimum fixed releases for the eMudhra CA incident. Add comments to keep the pins in sync.