Repository navigation
Conversation
It should also have a pretty measurable impact on memory footprint, although I haven't found a good way to benchmark memory usage in-benchmark yet. Also bumping to 0.7 as this changes the public API for `Ngram`. Additionally, removing TODOs about const generics, as they wind up making the API a little harder to use, and didn't yield any direct performance improvements (in fact, benchmarks seemed to suggest a few percentage points loss in performance).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should also have a pretty measurable impact on memory footprint, although I haven't found a good way to benchmark memory usage in-benchmark yet.
Also bumping to 0.7 as this changes the public API for
Ngram.Additionally, removing TODOs about const generics, as they wind up making the API a little harder to use, and didn't yield any direct performance improvements (in fact, benchmarks seemed to suggest a few percentage points loss in performance).