Repository navigation
session/tracker.go: clear debug shapes on transfer - #42
Merged
Merged
Conversation
- The tracker records PrimitiveShapes (a shape without a type is a removal) and removes them from the client in sendGameData, like entities, scoreboards and effects - Before, the client kept the shapes of the old server after a transfer or fallback, and the new server couldn't remove them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Debug shapes (
PrimitiveShapes) stay on the client's screen after a transferor fallback. The tracker clears entities, effects, boss bars, players and
scoreboards in
sendGameData, but not shapes, and the new server can't removethem because it never sent them.
Changes
dimension. A shape without a type is a removal, so it's forgotten.
clearShapessends a removal for every tracked shape insendGameData,along with the rest of the tracked state.
Notes
Requires
PrimitiveShapesto be decoded by the proxy, which spectrum-dfenables in cooldogedev/spectrum-df#18.