Skip to content

relative import extensions - #1906

Open
dynst wants to merge 5 commits into
cosmos:mainfrom
dynst:import-extensions
Open

dynst wants to merge 5 commits into
cosmos:mainfrom
dynst:import-extensions

Conversation

@dynst

@dynst dynst commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Groundwork for #1004

@webmaster128 webmaster128 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

import { AminoConverters } from "../../aminotypes.ts";

// https://github.com/cosmos/ibc-go/blob/07b6a97b67d17fd214a83764cbdb2c2c3daef445/modules/core/02-client/types/client.pb.go#L297-L312
// https://github.com/cosmos/ibc-go/blob/07b6a97b67d17fd214a83764cbdb2c2c3daef445/modules/index/core/02-client/types/client.pb.go#L297-L312

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

}

// https://github.com/cosmos/ibc-go/blob/a4ca39c59f770a0b6948947d5178d5f0914c3a17/modules/apps/transfer/types/tx.pb.go#L37-L56
// https://github.com/cosmos/ibc-go/blob/a4ca39c59f770a0b6948947d5178d5f0914c3a17/modules/index/apps/transfer/types/tx.pb.go#L37-L56

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

* Performs a delegation from a delegate to a validator.
*
* @see https://docs.cosmos.network/main/build/modules/staking#msgdelegate
* @see https://docs.cosmos.network/main/build/modules/index/staking#msgdelegate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Comment thread eslint.config.mjs Outdated
import js from "@eslint/js";
import typescriptEslint from "@typescript-eslint/eslint-plugin";
import importt from "eslint-plugin-import";
// eslint-disable-next-line import/extensions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this with ignorePackages?

@dynst
dynst force-pushed the import-extensions branch from dfbb4d3 to f1b3ceb Compare November 19, 2025 03:21
@dynst
dynst force-pushed the import-extensions branch from f1b3ceb to a5ca6cf Compare June 23, 2026 17:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants