Repository navigation
fix(encoding): Stop passing Infinity as bech32 decode limit - #1983
Open
jonathan-nansen wants to merge 1 commit into
Open
jonathan-nansen wants to merge 1 commit into
jonathan-nansen wants to merge 1 commit into
Conversation
|
PR author is not in the allowed authors list. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fromBech32defaultslimittoInfinityand passes it to@scure/base'sbech32.decode. Since@scure/base2.3.0,decodevalidateslimitas a safe integer unless it isfalse, so every default-argument call (andnormalizeBech32) throws:@cosmjs/encodingdepends on@scure/base@^2.0.0, so fresh installs pick up 2.3.0+ and hit this.bech32.decodehas acceptedlimit: falseto disable the length check since 2.0.0 (thelimit !== false && length > limitguard is unchanged across 2.0.0–2.4.0). This change maps an omitted limit, and an explicitInfinityfor callers who copied the old default, tofalse. Numeric limits pass through unchanged, and the public signature stayslimit?: number.Tests: the existing long-address test (>90 chars, default limit) covers the regression; added a case passing
Infinityexplicitly. Note thatyarn.lockcurrently resolves@scure/base@2.0.0, so CI won't reproduce theRangeErrorwithout a lockfile bump. I haven't run the suite locally.Fixes #1982