Repository navigation
chore: sync with LedgerHQ/app-cosmos v2.39.2 - #213
Closed
chcmedeiros wants to merge 14 commits into
Closed
chcmedeiros wants to merge 14 commits into
chcmedeiros wants to merge 14 commits into
Conversation
Merge develop into main following B2CA-2666
Merge develop into master (B2CA-2666)
Align master with P1
Bump version 2.38.19
Review fidelity, parser hardening, and Babylon wrapped staking support
…lares extractHDPath hard-coded 118' and 60', so a chain registering its own SLIP-0044 coin type could not be derived at all. Derive the accepted set from chainConfig[] instead: such a chain now needs nothing beyond its table entry, matching the table's own comment. Add Gonka (1200', hrp gonka) as one entry. The existing HRP-first lookup in checkChainConfig already refuses a declared HRP on any path other than its own, so gonka is refused on 118' the same way inj already is -- no separate exclusivity check is needed for it. Require the HRP on every coin type other than 118'. Only the generic Cosmos path has a meaningful default; elsewhere an omitted HRP would derive a key on that chain's path while defaulting the review screen to a cosmos1... address. Declare 44'/1200' in PATH_APP_LOAD_PARAMS -- the OS enforces this independently of the checks above; without it the device answers a generic 0x6400 that no code review can predict. Swap check_address now answers only for chains the app can also price and verify at signing time, instead of relying on a later chain-id mismatch. LIVE-36205
The version bump left the golden snapshots on 2.39.1, so the main menu test fails on the version screen on all five devices. Regenerates the *-mainmenu snapshots, the only ones the version screen appears in: 00004.png everywhere, plus 00010.png on nanox and nanos+ where the menu wraps around to it a second time -- compareSnapshots stops at the first mismatch, so that second one is never reported. Nothing else moved: the full suite passes at 200/200. LIVE-36205
feat(chain-config): add Gonka coin type 1200 with exclusive HRP resolution
Release 2.39.1 (stax_1.10.1_2.39.1_sdk_v26.6.1): merge into main
Merge develop into main
Sync with the version Ledger publishes and deploys.
|
PR author is not in the allowed authors list. |
Collaborator
Author
|
Closing: Cosmos has private PRs open with more changes, so we will sync after those land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
mainin sync with the publicLedgerHQ/app-cosmosmain, which carries v2.39.2, the version Ledger Live deploys.This branch merges
LedgerHQ/app-cosmos@maininto ourmain. The merge is clean, and it keeps the commit we have that Ledger does not.Merge note
Please merge with a merge commit (not squash or rebase). That keeps our history aligned with Ledger's, so future syncs stay fast-forwards.