Skip to content

fix jukebox music not stopping - #1476

Open
MEMOxiiii wants to merge 3 commits into
df-mc:masterfrom
MEMOxiiii:fix/jukebox-stop-music
Open

MEMOxiiii wants to merge 3 commits into
df-mc:masterfrom
MEMOxiiii:fix/jukebox-stop-music

Conversation

@MEMOxiiii

@MEMOxiiii MEMOxiiii commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Fixes jukebox music not stopping when the disc is taken out or the jukebox is broken, matching vanilla 1.26.50.

  • Music discs are now played with a PlaySound packet that carries a sound handle, like vanilla does.
  • Stopping a disc sends ClientboundUpdateSoundData with that handle, so the client stops the music. The old LevelSoundEvent RecordNull did not stop it.
  • The handle is made from the jukebox position, so the stop packet can find the sound again without keeping any extra state. Vanilla uses a counter instead, but the client only needs the same handle in both packets.

Verified against BDS.

Before

before.mp4

After

after.mp4

Comment thread server/session/world.go Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants