Repository navigation
Conversation
MEMOxiiii
approved these changes
Oct 31, 2026
MEMOxiiii
left a comment
MEMOxiiii
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Tested before and after the change
The hotbar slot updates correctly when switching servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session.Spawnsends the inventories but not the selected hotbar slot, so the client keeps whichever slot it had selected while the server uses the loadedHeldSlot. A client that is already in a world when it spawns, for example one moved between servers by a proxy, then holds a different item than the server thinks until it changes slot.This sends
PlayerHotBarwith the held slot after the inventories, as the vanilla server does after sending a player's inventory.