Repository navigation
test: fix CI on Linux, Windows and Node 26 - #4
Merged
Merged
Conversation
Compare icon renders with the committed macOS PNGs within a tolerance, since resvg builds for other platforms differ by a few anti-aliased pixels. Close the MapeoManager in e2e teardown so Windows can delete client.db. Drop Node 26 from CI until core moves off better-sqlite3 11.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 97.62% 98.10% +0.47%
==========================================
Files 10 10
Lines 632 632
Branches 91 91
==========================================
+ Hits 617 620 +3
+ Misses 15 12 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has failed on every platform but macOS arm64 since before the move to digidem. Three causes.
The render test compared PNG byte hashes generated on macOS arm64. resvg builds for other platforms differ by a few anti-aliased edge pixels in a handful of the 390 renders, at worst a mean of about 0.1 levels out of 255 (a different icon differs by about 90). The test now decodes each render and compares it with a committed macOS PNG, allowing a mean difference of 1. The reference renders are of the CC BY-NC default icons, noted in the README; they aren't in the npm package.
The e2e teardown closed the project but not the MapeoManager, so Windows couldn't delete the open client.db.
Node 26 fails at install: @comapeo/core 7.6.1 depends on better-sqlite3 11, which has no Node 26 build and doesn't compile against its V8. Node 26 is out of the matrix and the required checks until core moves on.