Repository navigation
Wrap the Dashboard's chips instead of squeezing their names - #6
Merged
farukkamcici merged 2 commits intoSep 30, 2026
Merged
Conversation
Owner
|
Thanks for the contribution @andostronaut, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Settings → Menu Bar, the Dashboard row put every grouped reading on a single line (
HStack). Once most modules were grouped there was not enough room, so SwiftUI squeezed each chip until its name broke into a column of single letters. The chips now keep their full width and wrap onto another line.Before
After
ChipFlowLayout) that places each one at its natural width and starts a new line when the next one would not fit.GroupedModuleChipisfixedSize()withlineLimit(1), so a name never breaks inside its capsule.How I verified it
swift testpasses inPackages/MetricsKitxcodebuild -project Mectrics.xcodeproj -scheme Mectrics -configuration Debug buildsucceeds with no new warnings — built unsigned like CI (CODE_SIGNING_ALLOWED=NO …); the app suite runs 181 tests, 0 failuresConventions checklist
String(localized:)or SwiftUIText0xcodegen generatewas run if files were added or removed;Mectrics.xcodeproj/is not committedCo-Authored-By:or "Generated with" trailers)