Skip to content

Fix ScheduleByWeek without WeeksInterval in CalendarTrigger #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joaocmendonca wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix ScheduleByWeek without WeeksInterval in CalendarTrigger #1558

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2df991c
fix: handle ScheduleByWeek without WeeksInterval in CalendarTrigger
joaocmendonca Feb 19, 2026
78abe86
Merge branch 'main' into fix/tasks-calendar-trigger-schedulebyday
joaocmendonca Jun 15, 2026
5e13500
Merge branch 'main' into fix/tasks-calendar-trigger-schedulebyday
joaocmendonca Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions dissect/target/plugins/os/windows/tasks/xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,10 +318,19 @@ def get_triggers(self) -> Iterator[GroupedRecord]:
days_between_triggers=int(days_between_triggers),
)

elif weeks_between_triggers := self.get_element("ScheduleByWeek/WeeksInterval", trigger):
days_of_week = [day.tag for day in trigger.find("ScheduleByWeek/DaysOfWeek/").iter("*")]
elif trigger.find("ScheduleByWeek/") is not None:
weeks_between_triggers = self.get_element("ScheduleByWeek/WeeksInterval", trigger)
# If WeeksInterval is not present, default to 1 (every week).
weeks_between_triggers = int(weeks_between_triggers) if weeks_between_triggers else 1

days_el = trigger.find("ScheduleByWeek/DaysOfWeek")
if days_el is not None:
days_of_week = [day.tag for day in list(days_el)]
else:
days_of_week = []

record = WeeklyTriggerRecord(
weeks_between_triggers=int(weeks_between_triggers),
weeks_between_triggers=weeks_between_triggers,
days_of_week=days_of_week,
)

Expand Down