Repository navigation
feat(deploy-candidate): Read apt dependencies from [tool.frappe-cloud] (backport #7973) - #7996
Merged
Merged
Conversation
The [deploy.dependencies.apt] table is not valid per PEP 518, which reserves all top-level tables except [tool.*]. Strict validators reject it. Read [tool.frappe-cloud] apt-dependencies too, like the builder does since frappe/agent#616. The legacy key still works, and the existing dedup lets an app list a package under both keys while it migrates. (cherry picked from commit ad07fd2)
Collaborator
|
🎉 This PR is included in version 0.179.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7996 +/- ##
=========================================
Coverage ? 66.34%
=========================================
Files ? 1142
Lines ? 114470
Branches ? 2171
=========================================
Hits ? 75949
Misses ? 38461
Partials ? 60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Apps declare extra apt packages in
pyproject.tomllike this:This table is not valid. PEP 518 reserves all top-level tables except
[tool.*]for future specifications. Strict validators such asvalidate-pyprojectreject the file.Change
Like the builder since frappe/agent#616, the Deploy Candidate now also reads a key in the
[tool.*]namespace:[deploy.dependencies.apt]key still works.Docs: https://docs.frappe.io/wiki-app/spaces/7ncdodb8sb/change-requests/91adai4u3o
This is an automatic backport of pull request #7973 done by [Mergify](https://mergify.com).