Repository navigation
v1.91.323.0 ship: proportional (scoped) second review pass after a blocking fix (GSTA-152 PR B) - #3596
Merged
Conversation
…52 PR A) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…locks uncapped review starts; short child return reconciles incomplete) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…cs match their evidence Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… maps it to a lane Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…152 PR A) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…so Windows can launch them Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ELOG via mergeChangelogs) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…s empty (GSTA-152 PR B review) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… own scope and gate scan (GSTA-152 PR B pass 2) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…truction (GSTA-152 PR B pass 3) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Contributor
E2E Evals: ⛔ NOT RUN on
|
|
😎 This pull request was merged. |
…geChangelogs) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
garrytan
added a commit
that referenced
this pull request
Oct 29, 2026
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
garrytan
force-pushed
the
gsta152-pr-b
branch
from
October 29, 2026 18:50
2ebf321 to
a924d74
Compare
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHIP_RECEIPT: pr=3596 head=7f92b29243de version=1.91.310.0 base=capy/token-cap-with-real session_kind=unattended depth=full
What changed
/ship's review-depth planner (
lib/review-depth.ts,bin/gstack-review-plan) now enforces "a full pass 1 always gets a full pass 2"; the token saving from scoped second passes applies only when pass 1 ran below full depth. Docs:docs/review-policy.md,ship/sections/review-army.md(.tmpl), CHANGELOG [Unreleased].Why
This narrows the plan Garry approved: gate-class PRs keep the full second pass, so the saving applies only to PRs below full depth. That's the safe direction, chosen after three review passes found holes in rebuilding the pre-fix gate class.
Blast radius
/ship review planning only. Gate-class and full-depth PRs behave as before (full pass 2); below-full PRs may get a scoped pass 2.
Review (4 passes)
Notes (informational, not looped):
lib/review-depth.ts:104:nextSteptreats a missingpass1Depthas below full for library callers; only the CLI defaults it to full.test/review-plan-cli.test.ts:188: assertion checksNEXT: fullbut no longer the reason.Validation
PREGATE_VERIFY: ok.Token cost
Pass 1 dispatches (counter deltas): security 373,254; testing 511,454; maintainability 364,113; performance 362,494; simplification 366,058; state-machines 234,661; red-team 1,016,168. Total 3,228,202 actual vs 52,010,000 projected (16.1x over-projection). Full projected-vs-actual table: handoffs/token-efficiency/ship-budget-projection-GSTA-152-prb.md (GStack Minder drive). Pass 4 fix-check: ledger projected 7,430,000 and refused; dispatched on the counter.
Approvals