Skip to content

Emdash/drag and drop ab085 - #3384

Open
mhealysn wants to merge 17 commits into
generalaction:mainfrom
mhealysn:emdash/drag-and-drop-ab085
Open

mhealysn wants to merge 17 commits into
generalaction:mainfrom
mhealysn:emdash/drag-and-drop-ab085

Conversation

@mhealysn

Copy link
Copy Markdown

Description

Give a short summary of what changed, why it's needed, and any important implementation notes.

Related issues

Link related issues. If this PR fixes an issue, mention it like: Fixes #123.

Testing

List the checks you ran, for example pnpm run format, pnpm run lint,
pnpm run typecheck, pnpm run test, and any manual testing.

Screenshot/Recording (if applicable)

Attach a screenshot, GIF, or recording of the change. This is optional, but helps reviewers
understand UI or workflow changes.

Checklist
  • I kept this PR small and focused
  • I ran a self-review before opening this PR
  • I ran the relevant local checks or explained why not
  • I updated docs when behavior or setup changed
  • I added or updated tests when behavior changed, or explained why not
  • I only added comments where the logic is not obvious
  • I used Conventional Commits for commit
    messages and, when possible, the PR title

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[High impact] The changes span project work, Jira imports, and shared agent status flows.

Fix saved manual moves before merging; they can hide an agent's current work on later turns.

Findings

  1. P1 Expired moves return ▶
  2. P2 Keyboard users cannot move cards ▶
Fix with agent prompt
### Issue 1
apps/emdash-desktop/src/core/features/projects/browser/stores/project-view.ts:46-48
Move a working task to Review, let the agent finish, then send another prompt. When the conversation returns to `working`, its key matches the old saved override. The card stays in Review instead of Running because the mismatched override was never removed.

Remove the saved override when the observed key first changes, and test a full status cycle.

### Issue 2
apps/emdash-desktop/src/core/features/projects/browser/components/task-view/task-board.tsx:108-112
Cards can only move through mouse dragging. The card's button opens the task, and there is no keyboard action for choosing another column. Add a keyboard-accessible move menu or equivalent controls so keyboard users can start backlog work and archive cards from the board.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR adds a project task board, Jira issue imports, and richer agent status hooks.

  • Project tasks appear on a board that follows their agent and pull request state.
  • Jira issues can become project tasks and keep their saved details in sync.
  • Claude and Codex report questions and work changes to the app.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Jira[Jira query and comments] --> Sync[Import or refresh task]
  Sync --> Task[Saved task]
  Hooks[Agent hooks] --> Status[Conversation status]
  Task --> Board[Project board]
  Status --> Board
  PR[Pull request status] --> Board
  Board -->|Backlog to Running| Agent[Create and start conversation]
  Board -->|Drop on Done| Confirm[Confirm archive]
Loading

Reviews (1) · Last reviewed commit: "feat(board): enable task card drag and d..." · Reviewed by Greptile

Comment on lines +46 to +48
boardOverride(taskId: string, agentStatusKey: string): BoardColumn | undefined {
const override = this.handle.value.boardOverrides?.[taskId];
return override?.agentStatusKey === agentStatusKey ? override.column : undefined;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Expired moves return

Move a working task to Review, let the agent finish, then send another prompt. When the conversation returns to working, its key matches the old saved override. The card stays in Review instead of Running because the mismatched override was never removed.

Remove the saved override when the observed key first changes, and test a full status cycle.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/emdash-desktop/src/core/features/projects/browser/stores/project-view.ts
Line: 46-48

Comment:
**Expired moves return**

Move a working task to Review, let the agent finish, then send another prompt. When the conversation returns to `working`, its key matches the old saved override. The card stays in Review instead of Running because the mismatched override was never removed.

Remove the saved override when the observed key first changes, and test a full status cycle.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Comment on lines +108 to +112
<li className="shrink-0" draggable onDragStart={(event) => onDragStart(event, taskId)}>
<Button
variant="secondary"
disabled={opening}
onClick={() => void open()}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Keyboard users cannot move cards

Cards can only move through mouse dragging. The card's button opens the task, and there is no keyboard action for choosing another column. Add a keyboard-accessible move menu or equivalent controls so keyboard users can start backlog work and archive cards from the board.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/emdash-desktop/src/core/features/projects/browser/components/task-view/task-board.tsx
Line: 108-112

Comment:
**Keyboard users cannot move cards**

Cards can only move through mouse dragging. The card's button opens the task, and there is no keyboard action for choosing another column. Add a keyboard-accessible move menu or equivalent controls so keyboard users can start backlog work and archive cards from the board.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing

1 participant