Repository navigation
fix: open the configured server from the Profile menu item - #393
Conversation
The Profile entry in the sidebar menu always opened https://pair.gethopp.app, also when the app is pointed at a self-hosted server. Use Constants.webAppUrl like the subscription link does, so it follows the custom server URL and falls back to the default one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
✅ Deploy Preview for hoppdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe Profile menu item now opens ChangesProfile URL configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The Profile link is intended to follow the configured web app URL. No actionable merge-blocking risk is evident from the supplied change context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for the contribution @mashpie |
Upstream gethopp#393 now opens the configured server from the Profile menu item, and gethopp#389 switched the web app images to WebP and compressed the bundle in selfhost/Caddyfile. Describe how our build still differs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
In the desktop app, the Profile entry in the sidebar menu always opens
https://pair.gethopp.app, also when a custom server URL is set in the settings. On aself-hosted setup that sends users to the hosted service instead of their own instance.
It now opens
Constants.webAppUrl, the same source the subscription link a few lines abovealready uses. That follows the custom server URL and falls back to the build's default
(
VITE_API_BASE_URL), so nothing changes for the hosted service.Testing
Typecheck and Prettier pass. I have not clicked through it in a running desktop build.
Summary by CodeRabbit