Skip to content

fix: open the configured server from the Profile menu item - #393

Merged
iparaskev merged 1 commit into
gethopp:mainfrom
uscreen:feat/profile-link-custom-server
Oct 6, 2026
Merged

iparaskev merged 1 commit into
gethopp:mainfrom
uscreen:feat/profile-link-custom-server

Conversation

@mashpie

@mashpie mashpie commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

What

In the desktop app, the Profile entry in the sidebar menu always opens
https://pair.gethopp.app, also when a custom server URL is set in the settings. On a
self-hosted setup that sends users to the hosted service instead of their own instance.

It now opens Constants.webAppUrl, the same source the subscription link a few lines above
already uses. That follows the custom server URL and falls back to the build's default
(VITE_API_BASE_URL), so nothing changes for the hosted service.

Testing

Typecheck and Prettier pass. I have not clicked through it in a running desktop build.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Profile menu link to use the configured web app address.

The Profile entry in the sidebar menu always opened
https://pair.gethopp.app, also when the app is pointed at a self-hosted
server. Use Constants.webAppUrl like the subscription link does, so it
follows the custom server URL and falls back to the default one.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@mashpie
mashpie requested a review from konsalex as a code owner October 6, 2026 11:44
@netlify

netlify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit daf4f5d
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/6ac4df36f38fe10008300c60
😎 Deploy Preview https://deploy-preview-393--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 944f9626-2b30-4b89-928c-42f054edfb47
📥 Commits

Reviewing files that changed from the base of the PR and between 0350ced and daf4f5d.

📒 Files selected for processing (1)
  • tauri/src/components/sidebar/Sidebar.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The Profile menu item now opens Constants.webAppUrl instead of a hard-coded Pair URL.

Changes

Profile URL configuration

Layer / File(s) Summary
Update Profile link
tauri/src/components/sidebar/Sidebar.tsx
The Profile menu item now uses Constants.webAppUrl as its destination.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to daf4f

The Profile link is intended to follow the configured web app URL. No actionable merge-blocking risk is evident from the supplied change context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: the Profile menu item now opens the configured server.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@iparaskev
iparaskev merged commit c35ef27 into gethopp:main Oct 6, 2026
16 checks passed
@iparaskev

Copy link
Copy Markdown
Contributor

Thanks for the contribution @mashpie

gabo963 pushed a commit to awkay/hopp that referenced this pull request Oct 8, 2026
Upstream gethopp#393 now opens the configured server from the Profile menu item,
and gethopp#389 switched the web app images to WebP and compressed the bundle in
selfhost/Caddyfile. Describe how our build still differs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants