Repository navigation
fix(producer): HDR renders report their encoder wait in render telemetry - #6841
Conversation
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head f5eef5f4. This closes the HDR gap from my #6839 review.
The named case (forwards useGpu=%s to the HDR encoder) fails 3 of 3 with captureHdrStage.ts reverted to #6839's head and passes at this head (30/30). Producer tsc is clean.
This PR is stacked on feat/render-capture-phase-timings, so CI, CodeQL and Windows don't run on it (they trigger only for main). They will gate it after the rebase onto main. The runs that did fire (regression, preview-regression, Player perf) are green.
The base branch was changed.
f5eef5f to
e8d8702
Compare
Edit accuracy: accurate 271 (base branch 271), smooth 126 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (2)
|
What
HDR and shader-transition renders now report
encoder_wait_avg_mslike the streaming and segmented paths do. Before, it was absent for them.Why
#6839 added the encoder's drain wait to render telemetry, but the layered-composite stage (
captureHdrStage.ts) also writes throughspawnStreamingEncoderand only keptdurationMsfrom its result, and the orchestrator's HDR branch only copiedencodeMs. So those renders had no encoder wait even though the encoder measured one.How
runCaptureHdrStagereturns the encoder'sdrainWaitMsasencoderDrainWaitMs, and the orchestrator's HDR branch records it inperfStages.encoderDrainWaitMs, the same as the other two paths.Size
Under 100 lines on purpose: it closes the one capture path #6839 missed, with its test.
Related work
Follows #6839.
Test plan
captureStreamingStage.test.tsrunCaptureHdrStageforwards useGpu=%s to the HDR encodernow also checks the stage returns the fake encoder's drain wait.undefinedinstead of 7.tsc,fallow auditand the comment ratchet clean, on Linux.