Skip to content

fix(producer): HDR renders report their encoder wait in render telemetry - #6841

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/hdr-encoder-wait-telemetry
Oct 30, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
fix/hdr-encoder-wait-telemetry

Conversation

@miguel-heygen

@miguel-heygen miguel-heygen commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

What

HDR and shader-transition renders now report encoder_wait_avg_ms like the streaming and segmented paths do. Before, it was absent for them.

Why

#6839 added the encoder's drain wait to render telemetry, but the layered-composite stage (captureHdrStage.ts) also writes through spawnStreamingEncoder and only kept durationMs from its result, and the orchestrator's HDR branch only copied encodeMs. So those renders had no encoder wait even though the encoder measured one.

How

runCaptureHdrStage returns the encoder's drainWaitMs as encoderDrainWaitMs, and the orchestrator's HDR branch records it in perfStages.encoderDrainWaitMs, the same as the other two paths.

Size

Under 100 lines on purpose: it closes the one capture path #6839 missed, with its test.

Related work

Follows #6839.

Test plan

heygengenesis[bot]
heygengenesis Bot previously approved these changes Oct 30, 2026

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head f5eef5f4. This closes the HDR gap from my #6839 review.

The named case (forwards useGpu=%s to the HDR encoder) fails 3 of 3 with captureHdrStage.ts reverted to #6839's head and passes at this head (30/30). Producer tsc is clean.

This PR is stacked on feat/render-capture-phase-timings, so CI, CodeQL and Windows don't run on it (they trigger only for main). They will gate it after the rebase onto main. The runs that did fire (regression, preview-regression, Player perf) are green.

Base automatically changed from feat/render-capture-phase-timings to main October 30, 2026 15:12
@miguel-heygen
miguel-heygen dismissed heygengenesis[bot]’s stale review October 30, 2026 15:12

The base branch was changed.

@miguel-heygen
miguel-heygen force-pushed the fix/hdr-encoder-wait-telemetry branch from f5eef5f to e8d8702 Compare October 30, 2026 15:15
@github-actions

Copy link
Copy Markdown
Contributor

Edit accuracy: accurate 271 (base branch 271), smooth 126 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (0)

Unstable (2)

  • seqplainkeys-none-center-r0-root-z100: tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo false, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true
  • seqplainkeys-none-pct-r0-nested-z100: tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo true, teleport true / tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo true, teleport true / tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo true, teleport true

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE · 0 resolved, 0 open, 0 new · f5eef5f4 → e8d87027. Rebased onto main with the same patch (only a hunk offset moved). The file passes 30/30, and the main-targeted CI, CodeQL and Windows checks are now green.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 3d942ee Oct 30, 2026
95 of 103 checks passed
@miguel-heygen
miguel-heygen deleted the fix/hdr-encoder-wait-telemetry branch October 30, 2026 18:44
@heygengenesis heygengenesis Bot mentioned this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant