Repository navigation
spec 022: duckdb-acl after spec 150 stage 4a - #22
Merged
Merged
Conversation
duckdb-acl f2f520f -> 4acccd7: specs 151 (a DDL's record is a PRAGMA that answers no row; the embedded quack collector skips it), 153 (a client's DDL over Flight runs as text), 154 (a record follows the client's ROLLBACK), 155 (a principal's error names nothing it was not shown) and 150 4a (a name in a management statement is read exactly as duckdb reads an identifier; every revoke of nothing is refused). The CLUSTER rules' names follow the identifier rule, a setting's name and the values stay words. No source list, ext-common or quack move. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LdLs2iBQygBKtsApdH9Sxi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec:
specs/022-pin-duckdb-acl-4a/spec.md.Moves duckdb-acl from f2f520f (the end of its spec 150 stage 3, which spec 020 followed) to 4acccd7.
PRAGMAand answers no row. The embedded quack collector skips it.For the CLUSTER rules (spec 020), names follow duckdb's identifier rule:
AS <alias>,IN GROUP,SECRET,FROM <repo>, an extension andDEPENDS ONare names. A keyword duckdb does not take as a name (a reserved word,full,left) or a leading digit now needs quotes, and the refusal says so.Nothing stored changes. The source list, ext-common and quack do not move, and acl-otel stays on its pin.
Tests
Locally with
HUGR_NODE_E2E=1 GEN=ninja make:test/sql/*: 14 files, 1043 assertions, green.make test-cpp: 4/4 green.I did not run the e2e (Keycloak, tresor-server, kista). duckdb-acl 4a's compatibility review checked the names this repository's tests and docs write: all of them still read.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LdLs2iBQygBKtsApdH9Sxi