Repository navigation
Version 1.3.35 - #723
Merged
Merged
Version 1.3.35#723
Conversation
A view switch flipped and flipped back, or a typed character deleted again, left the dot on and a draft on disk. A draft write that finds the document back on its save now retires the draft and takes the dot off, as undo already did. The media's length and picture flag, which settle after the project is signed, are left out of the comparison. Fixes #717
Twelve cards driven by driver.js 1.9.0 (vendored): a new recording and the Transcribe dialog, the transcript, strikethrough, the two views and the captions view itself, Recents and a project's three-dot actions, Export media and its dialog, Settings and the Take the tour row. Steps open what they describe and close it on the way out. Seen is one flag in the settings store. The first run waits for the intro project and stands down under automation. Fixes #718
The read-only gate disabled every button in the captions view. Play clip, the two cue buttons and the reading-rate badge only play or show something, so they stay active. Text, times, insert, merge and delete stay disabled. Fixes #719
Retimed cue bounds are rounded to milliseconds, as the retimed transcript's words are, and the chunker compares at that precision. A cue's end a few microseconds above the next cue's first word made that word the earlier cue's one word too many, and the cue lost its word times to the syllable spread. Fixes #720
…and Baseline used where it stalls WebKit's H.264 encoder on macOS 27.0 takes a few frames in Main or High profile in the default latency mode and never emits a packet (WebKit bug 324827, fixed but not shipped), so a re-encoding export sat on its status line for ever. The page now asks the encoder once per load, eight frames at 640x360, and only where no packet comes within a second and a half does the export use Baseline profile, saying so in the status. Nothing changes where the default works. Fixes #721
The AAC encoder's priming run was written as the start of the audio track, so Chrome, ffmpeg and VLC heard every re-encoded export 40 ms late. The run is measured once per page and the track starts that much before zero, which mediabunny 1.61.3 (vendored, with its mp3 encoder) writes as an edit list. Apple's players strip the run on their own and would count it twice, so the finished file also gets AAC roll sample groups, which every player reads right. Fixes #722
Sampling every 100 ms missed the note on a small export under load (#721).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.3.35.
Fixes #718
Fixes #717
Fixes #719
Fixes #720
Fixes #721
Fixes #722