Repository navigation
Conversation
…able modesets A modeset commit with ALLOW_MODESET resets the CRTC, so an in-flight page-flip is cancelled or superseded and its completion event arrives stale or is lost. Two paths left the connector frame scheduler counting the dead flip as pending forever: - handlePageFlip discarded stale events without completing the frame state, so every following buffer commit was rejected with Cannot commit when a page-flip is awaiting and the compositor spun retrying. - commitState invalidated the in-flight flip only when the modeset enabled the output; a disable commit with a flip in flight left the same stuck state behind. Complete the scheduler state when a stale event has no newer flip in flight, and invalidate the flip state on any modeset commit that finds one, disable included. Observed on NVIDIA GB10 single-GPU with Hyprland 0.57.1 where the render loop wedged after a startup modeset raced the first flip. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Hi @YF36, Thanks for your contribution! Unfortunately, Hyprland and hypr* no longer To get vouched, please see our contributing guide at wiki.hypr.land/Contributing-and-Debugging This PR has been closed automatically and will not be re-opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…able modesets
A modeset commit with ALLOW_MODESET resets the CRTC, so an in-flight page-flip is cancelled or superseded and its completion event arrives stale or is lost. Two paths left the connector frame scheduler counting the dead flip as pending forever:
Complete the scheduler state when a stale event has no newer flip in flight, and invalidate the flip state on any modeset commit that finds one, disable included.
Observed on NVIDIA GB10 single-GPU with Hyprland 0.57.1 where the render loop wedged after a startup modeset raced the first flip.