Skip to content

drm: complete stale page-flip bookkeeping and clear flip state on dis… - #492

Closed
YF36 wants to merge 1 commit into
hyprwm:mainfrom
YF36:drm/stale-flip-bookkeeping
Closed

YF36 wants to merge 1 commit into
hyprwm:mainfrom
YF36:drm/stale-flip-bookkeeping

Conversation

@YF36

@YF36 YF36 commented Nov 12, 2026

Copy link
Copy Markdown

…able modesets

A modeset commit with ALLOW_MODESET resets the CRTC, so an in-flight page-flip is cancelled or superseded and its completion event arrives stale or is lost. Two paths left the connector frame scheduler counting the dead flip as pending forever:

  • handlePageFlip discarded stale events without completing the frame state, so every following buffer commit was rejected with Cannot commit when a page-flip is awaiting and the compositor spun retrying.
  • commitState invalidated the in-flight flip only when the modeset enabled the output; a disable commit with a flip in flight left the same stuck state behind.

Complete the scheduler state when a stale event has no newer flip in flight, and invalidate the flip state on any modeset commit that finds one, disable included.

Observed on NVIDIA GB10 single-GPU with Hyprland 0.57.1 where the render loop wedged after a startup modeset raced the first flip.

…able modesets

A modeset commit with ALLOW_MODESET resets the CRTC, so an in-flight
page-flip is cancelled or superseded and its completion event arrives
stale or is lost. Two paths left the connector frame scheduler
counting the dead flip as pending forever:

- handlePageFlip discarded stale events without completing the frame
  state, so every following buffer commit was rejected with
  Cannot commit when a page-flip is awaiting and the compositor spun
  retrying.
- commitState invalidated the in-flight flip only when the modeset
  enabled the output; a disable commit with a flip in flight left the
  same stuck state behind.

Complete the scheduler state when a stale event has no newer flip in
flight, and invalidate the flip state on any modeset commit that finds
one, disable included.

Observed on NVIDIA GB10 single-GPU with Hyprland 0.57.1 where the
render loop wedged after a startup modeset raced the first flip.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Hi @YF36,

Thanks for your contribution! Unfortunately, Hyprland and hypr* no longer
accept contributions from unvouched contributors.

To get vouched, please see our contributing guide at wiki.hypr.land/Contributing-and-Debugging

This PR has been closed automatically and will not be re-opened.

@github-actions github-actions Bot closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant