Repository navigation
drm: skip modifiers already in the plane format list - #499
Open
dar1k-ness wants to merge 1 commit into
Open
dar1k-ness wants to merge 1 commit into
dar1k-ness wants to merge 1 commit into
Conversation
Since 7.3 amdgpu exposes IN_FORMATS on the cursor plane for older cards too (hit this on an RX 580), so LINEAR ends up in the list twice. The gbm fallback only handles the list being exactly LINEAR, so with the dup the cursor bo gets allocated with DRM_FORMAT_MOD_INVALID, which can't go on the cursor plane and the cursor is just gone.
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #476
Since 7.3 amdgpu exposes IN_FORMATS on the cursor plane for older cards too, so LINEAR ends up in the list twice. The gbm fallback only handles the list being exactly LINEAR, so with the dup the cursor bo gets allocated with DRM_FORMAT_MOD_INVALID, which aquamarine then refuses to commit to the cursor plane, so the cursor is just gone.
This just checks if the modifier is already there before adding it.
Hit this on an RX 580, same thing on an RX 570 here: #476 (comment)
Fine on 7.2.15 (with aquamarine 0.15.1), broken on 7.3.4.
before:
cursor bo is INVALID, no fb on the cursor plane, no cursor
after:
cursor bo is LINEAR, cursor plane has an fb, cursor is back
Tested on Arch, linux 7.3.4-arch1-1, Hyprland 0.57.2, aquamarine 0.16.0, Mesa 26.2.7