Repository navigation
fix(grafana): drop panels for a fault detector the stack never runs - #103
Open
pucedoteth wants to merge 1 commit into
Open
pucedoteth wants to merge 1 commit into
pucedoteth wants to merge 1 commit into
Conversation
The dashboard queried fault_detector_* metrics in "Fault Check Status" and "System Security Monitoring", but docker-compose has no fault-detector service and Prometheus scrapes none, so those queries always returned no data. Remove the dead panel and query, and widen the two remaining panels in that row to fill the gap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L75E8Ap183JW1mDfv8arqR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simple_node_dashboard.jsonqueriesfault_detector_*metrics in two places:fault_detector_highest_checked_batch_index,fault_detector_highest_known_batch_indexfault_detector_is_currently_mismatchedThis stack has no fault-detector service.
docker-compose.ymldoesn't run one anddocker/prometheus/prometheus.ymlscrapes onlyhealthcheck,op-nodeandop-reth, so these queries always return no data. That has been the case since the dashboard was carried over from simple-optimism-node, and it makes a healthy node look broken.Changes
fault_detector_is_currently_mismatchedquery from "System Security Monitoring". The panel keepshealthcheck_is_currently_diverged, which this stack does produce.Testing
fault_detectorreference remains.reth_blockchain_tree_safe_block_height,reth_jemalloc_*,reth_io_*,reth_process_cpu_seconds_total) exist in op-reth's metrics code.