Repository navigation
Replace tslint with ESLint and lint in CI - #360
Merged
Merged
Conversation
isc-klu
force-pushed
the
eslint
branch
5 times, most recently
from
October 16, 2026 16:29
3c4709b to
1a968a7
Compare
isc-klu
marked this pull request as ready for review
October 16, 2026 17:11
Collaborator
|
@isc-klu I suggest merging this PR last because it will have to be updated with the other changes. |
gjsjohnmurray
previously approved these changes
Oct 20, 2026
tslint has been deprecated since 2019 and crashes on TypeScript 5+; its recommended config also demanded spaces while the codebase uses tabs, so `npm run lint` reported 2679 indent errors and nobody ran it. Switch to ESLint + typescript-eslint recommended, fix the 10 findings and drop the dead tslint directives, then run lint on every push.
isc-bsaviano
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tslint has been deprecated since 2019 and is not usable.
tslintwitheslint+typescript-eslint, usingrecommendedpresets in a flateslint.config.mjs.tslint.jsonand the stale, never-wired-up.eslintrc.json/.eslintignore.tslint:disablecomments.npm run lintto both CI workflows before compile.