Repository navigation
[sigma] Fixes WebGL errors in node and edge label picking - #1563
Merged
jacomyal merged 5 commits intoOct 26, 2026
Merged
Conversation
gdlambda
marked this pull request as draft
October 21, 2026 15:10
gdlambda
marked this pull request as ready for review
October 21, 2026 15:17
Owner
|
Hi @gdlambda, and thanks a lot for this PR, and for the very clear issue! I checked it locally:
Two notes, though:
So, I'm using this occasion to update the contributor guide, sorry for the timing. I'd be happy to rework your commit myself: Thanks again 🙏 |
Contributor
Author
|
Yeah @jacomyal I'm fine with that :D Thank you! |
Details: - Applies ?camera=x,y,ratio,angle after Sigma construction
This commit fixes jacomyal#1544. Details: - Adds keepUpright edge label option, defaulting to true - Reverses labels whose path points left on screen - Keeps above/below positions relative to the text - Aligns label backgrounds and picking with the text - Updates core/events snapshot for upright labels
Details: - Adds keepUpright toggle to the edge label styles example - Lets example e2e cases pass URL params and snapshot variants - Snapshots one rotated, zoomed edge with and without keepUpright
This commit adds (currently failing) regression tests for jacomyal#1562. Co-authored-by: Alexis Jacomy <alexis.jacomy@gmail.com>
This commit fixes jacomyal#1562. It writes fragColor before discard in both node and edge label picking shader. Co-authored-by: Alexis Jacomy <alexis.jacomy@gmail.com>
jacomyal
force-pushed
the
fix/label-picking-fragment-output
branch
from
October 26, 2026 16:20
a8f76ba to
36dab07
Compare
Owner
|
Awesome, thanks! |
Contributor
Author
|
Thank you very much 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
Node and edge label picking shaders discard fragments without writing
fragColor. Chromium reportsGL_INVALID_OPERATION: Active draw buffers with missing fragment shader outputs.Fixes #1562.
What is the new behavior?
Both shaders initialize
fragColorbefore discarding, following the suggested fix. This keeps the fragment output active without changing visible rendering or picking behavior.Other information
Added regression tests for node and edge label rendering. Both reproduce the WebGL error before the fix and pass afterward.