Repository navigation
fix(luxtts): readable error when text is too short for the vocoder - #1199
Open
vincentfranstyo wants to merge 1 commit into
Open
vincentfranstyo wants to merge 1 commit into
vincentfranstyo wants to merge 1 commit into
Conversation
Very short input produces fewer feature frames than the vocoder's Conv1d kernel and torch raises a raw padding RuntimeError that the UI shows as-is. Catch that specific error and raise a ValueError telling the user to use longer text. Other RuntimeErrors still propagate.
doublesharp
added a commit
to doublesharp/voicebox-ds
that referenced
this pull request
Oct 29, 2026
Use the shared QueryClient for offline requests, preserve custom server URLs through startup and migration, retain capture decode diagnostics, preserve refinement language, accept supported STT languages, and explain LuxTTS short-input errors. Adapt upstream PRs jamiepine#1208, jamiepine#1204, jamiepine#1219, jamiepine#1218, jamiepine#1198, jamiepine#1199, jamiepine#1220 and jamiepine#1180; retain remote reconnect refreshes and correctly migrate the legacy bundled port. Wait for the preview output context to resume before playing. Cancel superseded starts and release preview nodes/object URLs on replacement, completion, failure and unmount. Add CI regressions for the upstream integration and preview lifecycle. Validation: 292 frontend tests on this candidate; 414 frontend tests with the working UI changes; 53 backend tests; app/web/Tauri frontend typechecks and both frontend builds. Independent review accepted the playback change. Native first-click/autoplay, acoustic output, packaging and model quality remain unverified. Co-authored-by: vincentfranstyo <66989751+vincentfranstyo@users.noreply.github.com> Co-authored-by: maxazure <405711+maxazure@users.noreply.github.com> Co-authored-by: FelixKruger <262215022+FelixKruger@users.noreply.github.com> Co-authored-by: Tony25032 <141424750+Tony25032@users.noreply.github.com> Co-authored-by: mvoloch <274143174+mvoloch@users.noreply.github.com> Co-authored-by: Lvigentini <11659311+Lvigentini@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generating with LuxTTS on a short input like "This is a test" fails every time with a raw torch error shown in the UI:
The text produces too few feature frames for the Vocos vocoder's
Conv1dembed layer (kernel size 7).Fix
In
LuxTTSBackend.generate(), catch that specificRuntimeErroraroundgenerate_speech()and raise aValueErrorwith a clear message ("Text is too short for LuxTTS. Try a longer sentence or another engine."). The generation service already storesstr(e)as the generation error, so this message is what the user sees. Any otherRuntimeErroris re-raised unchanged.I went with catching the error rather than a fixed minimum character count, because the frame count depends on the text and the voice prompt, so a hard-coded threshold would either reject valid input or miss some crashes.
Testing
backend/tests/test_luxtts_short_text.pywith a fake model: the kernel-size error becomes aValueError, and an unrelatedRuntimeErrorstill propagates. The first test fails onmainand passes with this change.ruff check/ruff format --checkclean on the new test.Fixes #1046