Repository navigation
feat(omnivoice): add Vietnamese (vi) to the language list - #1202
Open
wei668899-luo wants to merge 1 commit into
Open
wei668899-luo wants to merge 1 commit into
wei668899-luo wants to merge 1 commit into
Conversation
OmniVoice covers 600+ languages, but the API enum and the frontend language table only carried the 23 codes that predate the engine, so Vietnamese was advertised nowhere and a language=vi request was rejected by the request patterns with a 422. The model card lists it as OmniVoice ID `vi` (ISO 639-3 `vie`, ~8.5k hours of training data), so unlike Arabic's `arb` no code override is needed. Widen the pattern on VoiceProfileCreate, GenerationRequest and SpeakRequest, list `vi` in the omnivoice model config and add the label to the language table. The new test in backend/tests/test_omnivoice_compat.py pins the API pattern against the advertised engine list, so a language can no longer be advertised by the engine and rejected by the request models at the same time.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OmniVoice covers 600+ languages, but the API enum and the frontend language
table only carried the 23 codes that predate the engine, so Vietnamese was
advertised nowhere and a language=vi request was rejected by the request
patterns with a 422. The model card lists it as OmniVoice ID
vi(ISO 639-3vie, ~8.5k hours of training data), so unlike Arabic'sarbno code overrideis needed.
Widen the pattern on VoiceProfileCreate, GenerationRequest and SpeakRequest,
list
viin the omnivoice model config and add the label to the language table.The new test in backend/tests/test_omnivoice_compat.py pins the API pattern
against the advertised engine list, so a language can no longer be advertised
by the engine and rejected by the request models at the same time.