Repository navigation
Conversation
Evaluate a plain callable before the right-hand wait strategy, preserving stateful delays and exception order. Add public retry-loop regressions. AI assistance: OpenAI Codex.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 21:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
callable + wait_strategyconstructs the wait combination in reverse operand order. Stateful callbacks can consequently schedule a different delay fromwait_combine(callable, strategy): the public retry-loop regressions record 2.1 seconds instead of the intended 1.2. It can also raise the right callback's exception before invoking the left callback.Construct
wait_combine(other, self)in the reflected callable branch. Integer zero/sum identity and nonzero-number rejection are unchanged. Add five tests for callback order, exception short-circuiting, sum compatibility and synchronous/asynchronous retry delays, plus documentation and a Reno note.This is distinct from #724's operand validation and #749's large-sum recursion handling; neither corrects this reflected evaluation order.
Validation on Linux / Python 3.12.14:
Other interpreters, operating systems and hosted checks are not claimed. Prepared and tested with OpenAI Codex assistance; no human review is claimed.