Repository navigation
Accept callable stop conditions in combinator types - #760
Closed
shreyans-chowdry wants to merge 1 commit into
Closed
shreyans-chowdry wants to merge 1 commit into
shreyans-chowdry wants to merge 1 commit into
Conversation
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom stop functions are accepted by
Retrying(stop=...)and work at runtime insidestop_anyandstop_all, but the two combinator constructors only annotatestop_base. This makes otherwise valid combinations fail type checking.Use the existing
StopBaseTalias for their arguments, consistent withBaseRetrying. The regression test combines a typed custom attempt-limit function withstop_after_delay, checks both combinators' results, and is included in the repository mypy run. Before the annotation change, mypy reports two argument-type errors in that test. Afterward it passes; runtime behavior is unchanged.Validation on Python 3.12.4/macOS:
Includes a release note. Investigated, implemented, and tested with OpenAI Codex assistance; found during source review, not a production incident.