Repository navigation
Conversation
Explain that stop conditions do not interrupt running attempts.
Describe the elapsed-time and upcoming-wait check.
Record the documentation correction.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stop_before_delaydocs read as if it guarantees a timeout for the whole call. It checks the elapsed time plus the next wait, but it cannot interrupt a running attempt.This clarifies the distinction in the guide and API docs, and adds a fixed-wait example showing where retries stop. Runtime behavior is unchanged.
Checked on Python 3.14: 185 tests, Ruff, mypy, and the Sphinx doctest and HTML builds passed. A simulated clock also confirmed the four-attempt example and that a successful call can finish after the limit.