Repository navigation
Conversation
M_2_PI from math.h is 2/pi (~0.637), not 2*pi. Using it when wrapping the differential phase into [-pi, pi] barely moves the value, so large phase steps stay mis-wrapped. The rest of liquid-dsp (and the unwrap autotests) already use 2*M_PI for this. Fixes jgaeddert#459
|
好啊,邮件收到啦!
Hi, your email is arrived safely
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ofdmframesyncwraps the differential phase error withM_2_PI. In<math.h>,M_2_PIis 2/pi (~0.637), not 2*pi. That means large phase steps are barely reduced and stay outside the intended [-pi, pi] range. Elsewhere in liquid-dsp (and in the unwrap autotests) the wrap correctly uses2*M_PI.This change matches that convention.
Fixes #459
Test plan
make check— 1349 tests / 0 failures (includesofdmframesync_acquire_*,ofdmframesync_config,ofdmflexframe_*)