Repository navigation
Conversation
Author
|
Whoops, was meant to open that on my own fork; not fully tested yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in Windows build using the Visual Studio Clang toolset, behind a new
ENABLE_CLANG_CLoption (default OFF) pluswindows-clangcl-*CMake presets for x64/Win32 × shared/static. Default configures behave exactly as before — verified MinGW/GCC-isms untouched, and a default VS/clconfigure passes with detection uncapped.Library sources (all
_WIN32/_MSC_VER-guarded, matching surrounding idiom):timer.c: QPC wall clock +GetProcessTimesCPU time in place ofgettimeofday/getrusageruntime.c:__cpuidex/_xgetbvin place of inline asmmsb_index.c:_BitScanReversein place of inline asmlogging.c: localstrsepplusunistd.hguardlibliquid.c:unistd.hguardBuild system:
cmake/clangcl/complex.hshim: UCRT<complex.h>predates C99_Complex, so clang-cl builds stand this in via-I(scalar decompose for real/imag/conj/abs/arg, forward to UCRT struct routines for transcendentals)WINDOWS_EXPORT_ALL_SYMBOLS(no export macros in-tree) and links the clang builtins archive, located relative to the compiler so VS-bundled and standalone LLVM both workc mlink guarded off Windows; autotest log dir creation viacmake -E(portable, identical elsewhere)ENABLE_CLANG_CLrow plus a Windows section (VS 2022+, preset commands)Known limits (deliberate):
-mavxon the command line, but the AVX sources share translation units with the portable/runtime-dispatch code that must stay baseline-safe. Lifting it needs the.avx.cfiles split into separate TUs first.getopt.h(plusunistd.hfor autotest). A getopt port is separate follow-up work.