Repository navigation
test(interactive): fix Qt ownership and signal checks - #641
Merged
Merged
Conversation
Register the layout containers so garbage collection cannot delete their editors before pytest-qt closes them. Follow-up to #640.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 310 310
Lines 119969 119969
Branches 20319 20319
=======================================
Hits 111190 111190
- Misses 4962 4964 +2
+ Partials 3817 3815 -2 ☔ View full report in Codecov by Harness. |
kmnhan
marked this pull request as ready for review
November 2, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two Qt test failures: a deleted parameter editor during teardown and a PySide6 smoke-test hang during signal cleanup.
The four standalone parameter-item tests now register
item.layoutWidgetwithqtbot. This keeps the owning container alive through cleanup and prevents the editor from being deleted between the validity check andclose().The pocket and image edit tests now record their synchronous notifications and require exactly one emission. They retain all state and geometry assertions. This avoids disconnecting the pytest-qt callback during signal emission. A normal Linux diagnostic run reproduced the hang and captured this native path: signal disconnect, Shiboken feature lookup, Python garbage collection, widget/action destruction, and a blocked Qt mutex. The exact collected widget was not identified. This test-only change avoids the observed trigger.
Validation:
This is a follow-up to #640. No dependent data or documentation PRs.