Repository navigation
fix: clean up JSON streams replaced by null - #2014
Open
Aurantium-47 wants to merge 1 commit into
Open
Aurantium-47 wants to merge 1 commit into
Aurantium-47 wants to merge 1 commit into
Conversation
Call the existing stream cleanup before returning the serialized JSON null body. Assisted-by: OpenAI GPT-6 <noreply@openai.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The change cleans up the replaced stream while preserving the JSON null response. No merge-blocking risk remains in the reviewed change. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: cleaning up an existing JSON stream when the response body is replaced with null. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Reviewer's GuideThe fix updates JSON body replacement to clean up an existing response stream before returning, while preserving the established null serialization and response metadata. New regression tests verify cleanup for both null and undefined replacements and confirm the resulting body, status, and content type. Sequence diagram for JSON response body replacement cleanupsequenceDiagram
participant Caller
participant Response
participant PreviousStream
Caller->>Response: body replacement with null or undefined
Response->>Response: cleanupPreviousStream()
Response->>Response: set _body to null
Response-->>Caller: return
PreviousStream-->>Response: stream is cleaned up
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2014 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 9 9
Lines 2144 2145 +1
=======================================
+ Hits 2142 2143 +1
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Node.js response stream has
Content-Type: application/json, replacing it withnullorundefinedserializes the JSON body as'null'and returns before cleaning up the old stream. The abandoned stream stays alive until the response finishes, unlike other non-stream body replacements.Call the existing cleanup helper before this return. Regression tests cover both values and check that the JSON body, status and content type are preserved.
Validation on Windows with Node.js 24.15.0 / npm 11.12.1:
node --test __tests__/response/body.test.js: 36 passed.npm run test:coverage: 468 passed, 0 failed or skipped.npm run lintandgit diff --check: passed.AI assistance: implemented and tested with OpenAI GPT-6.
Checklist
No commitlint command or configuration is present in this checkout; the commit uses the existing
fix:convention.Summary by Sourcery
Ensure JSON stream replacements with null or undefined clean up the previous stream before returning.
Bug Fixes:
Tests:
Summary by CodeRabbit
nullorundefinedin a non-empty JSON response now serializes the body asnulland properly closes the original stream. The response retains its status and JSON content type. This prevents the previous stream from being left open when the JSON body is replaced.