Repository navigation
Conversation
BinaryData is encoded again when the object is printed, so encoding the file first made the manifest decode to a base64 string. Signed-off-by: Dean Chen <862469039@qq.com>
kubernetes-prow
Bot
added
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: locker95 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
size/M
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
ConfigMap.BinaryDatais base64-encoded when the object is printed. Encoding the file bytes first meant something likeconfigs.tarshowed up as base64-of-base64, so the mounted file wasn't the original.Fixtures under configmap-volume now expect one encoding, and a unit test checks that the marshaled value decodes back to the raw bytes.
Which issue(s) this PR fixes:
Fixes #2082
Special notes for your reviewer: