Repository navigation
[Integrations] Support dark mode whiteIcon, circular badges, and card layout sizing #8170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tejaswiverma121-byte
wants to merge
14
commits into
layer5io:master
Choose a base branch
from
tejaswiverma121-byte:fix/8146-integration-component-icons-dark-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c4901bc
fix(integrations): support dark mode whiteIcon and standardize compon…
tejaswiverma121-byte 66a1879
fix(integrations): circular icon badges, expand card size, and align …
tejaswiverma121-byte 334737d
fix(integrations): improve icon fallback robustness, initial render, …
tejaswiverma121-byte f495264
Merge branch 'master' into fix/8146-integration-component-icons-dark-…
tejaswiverma121-byte 9bd650d
fix(integrations): use unique key with index in component grid
tejaswiverma121-byte bead3ba
fix(integrations): make component icon fallback theme-aware
tejaswiverma121-byte f7ac96a
fix(integrations): try alternate component icon before integration fa…
tejaswiverma121-byte c79d1c6
fix(integrations): initialize component grid as empty until icons val…
tejaswiverma121-byte 574af28
Merge branch 'master' into fix/8146-integration-component-icons-dark-…
tejaswiverma121-byte da49eaf
fix(integrations): prioritize integration fallback icon over alternat…
tejaswiverma121-byte f959735
Merge branch 'master' of https://github.com/layer5io/layer5 into fix/…
tejaswiverma121-byte b072c7f
fix(integrations): add onError safety net and use validComponents count
tejaswiverma121-byte db39b88
Merge branch 'master' into fix/8146-integration-component-icons-dark-…
tejaswiverma121-byte 293fd50
fix(integrations): revert unrelated formatting, drop svg swap, and fi…
tejaswiverma121-byte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
5 changes: 1 addition & 4 deletions
5
...pu/icons/components/node-feature-group/icons/color/node-feature-group-color.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 109 additions & 30 deletions
139
src/sections/Meshery/Meshery-integrations/Individual-Integrations/ComponentsGrid.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.