Repository navigation
Make pfn compile-fail tests readable - #461
Merged
Merged
Conversation
Each scenario is a named `#ifdef LIBFN_REJECT_<scenario>` block beside its positive control, and CMake derives one test per guard. Assisted-by: Claude:claude-opus-5-5
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🤖 Augment PR SummarySummary: Refactors pfn compile-fail tests for top-to-bottom readability without changing library code.
🤖 Was this summary useful? React with 👍 or 👎 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Restructures the compile-fail tests from #459 so they can be read top to bottom. Each scenario is a named
#ifdef LIBFN_REJECT_<scenario>block intests/pfn/reject/, right after a positive control that differs only in what makes it fail. CMake reads the guards from each source: the source must build as is, and each guard becomes aWILL_FAILtest named after it. Coverage is unchanged at 41 scenarios per mode.Checked locally on gcc 16.2 and clang 22.1: the full suite passes, and against the pfn headers from before #459 all 41 reject tests fail while both sources still build. This PR's CI is the first MSVC run.
Assisted-by: Claude:claude-opus-5-5