Skip to content

Update FindDPCPP.cmake - #802

Merged
thilinarmtb merged 5 commits into
developmentfrom
update_finddpcpp_cmake
Oct 21, 2025
Merged

thilinarmtb merged 5 commits into
developmentfrom
update_finddpcpp_cmake

Conversation

@thilinarmtb

@thilinarmtb thilinarmtb commented Oct 16, 2025 •

Copy link
Copy Markdown
Collaborator

Description

Use the vendor CMake package to find DPCPP.

Todo

  • Figure out how to handle OCCA_DPCPP_COMPILER_FLAGS when using vendor packages
  • Should we support add_sycl_to_target() command?

@thilinarmtb
thilinarmtb changed the base branch from main to development October 16, 2025 19:41
@thilinarmtb
thilinarmtb marked this pull request as draft October 16, 2025 19:41
@thilinarmtb
thilinarmtb marked this pull request as ready for review October 16, 2025 22:37
Comment thread cmake/FindDPCPP.cmake Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Switch FindDPCPP.cmake to prefer the vendor package (IntelSYCL) and align variables from SYCL_* to DPCPP_*.

  • Add find_package(IntelSYCL QUIET) with mapping to DPCPP_* variables
  • Rename SYCL_* variables to DPCPP_* and update CMakeLists messages accordingly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
cmake/FindDPCPP.cmake Introduces vendor-based discovery (IntelSYCL), renames variables, and adjusts include/library handling and flags.
CMakeLists.txt Updates log messages to use the new DPCPP_* variables.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cmake/FindDPCPP.cmake Resolved
Comment thread cmake/FindDPCPP.cmake Resolved
Comment thread cmake/FindDPCPP.cmake Resolved
@thilinarmtb
thilinarmtb force-pushed the update_finddpcpp_cmake branch 2 times, most recently from 2b554e4 to 29f85cc Compare October 17, 2025 01:34
@thilinarmtb
thilinarmtb force-pushed the update_finddpcpp_cmake branch from 29f85cc to 03252d3 Compare October 17, 2025 01:34
@thilinarmtb
thilinarmtb requested a review from Copilot October 17, 2025 01:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cmake/FindDPCPP.cmake Resolved
Comment thread cmake/FindDPCPP.cmake Resolved
@thilinarmtb

thilinarmtb commented Oct 20, 2025 •

Copy link
Copy Markdown
Collaborator Author

@kris-rowe : I think this is ready to review. Please let me know if you have other comments.
I can add support for add_sycl_to_target() in a separate PR if that is required.

@thilinarmtb
thilinarmtb force-pushed the update_finddpcpp_cmake branch from ccd488d to 36dba21 Compare October 20, 2025 19:01
@thilinarmtb
thilinarmtb force-pushed the update_finddpcpp_cmake branch from 36dba21 to 2ed41e5 Compare October 20, 2025 19:04
@thilinarmtb
thilinarmtb merged commit 95401b1 into development Oct 21, 2025
3 checks passed
@thilinarmtb
thilinarmtb deleted the update_finddpcpp_cmake branch October 21, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants