Repository navigation
[xegpu][examples] Convert maximum to maxnum for faster reductions. - #306
Merged
Merged
Conversation
Contributor
Author
|
in sync with main. I installed latest torch-mlir and tested the attention cases. please merge when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent LLVM change causes a significant perf degradation in attention example. This is caused by how SPIRV target lowers
vector.reductionops withmaximumfkind. It seems with the recent changes causesmaximumfto emit extra checks causing more instructions being executed in the hot fusion loop.As a temporary solution this PR converts the
maximumtomaxnumfkind after all fusions are done. This assumesignore NaNbehavior which the caller needs to make sure.Note: In my view, proper fix for this involve propagating user attached
nnannszflags viavector.multi_red->vector.reduciton-> LLVM -> SPIRV. currently there is no support for such propagation.Assisted by: Codex