Repository navigation
Translate recent Japanese comments into English and correct the StickS3 speaker note - #427
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Japanese comments added in recent changes are translated into English. Each comment was checked against the code while translating. No code is changed.
M5Unified.inl: the StickS3 ES8311 branch said itselsealso stops the speaker "when the target is not the internal speaker". That was copied from the CoreS3 branch; on StickS3 theelseis reached only when disabling, and the comment now says so.M5Unified.inl,Power_Class.inl/.hpp,Mic_Class.inl,Speaker_Class.inl: comments translated. The I2S clock notes now say that the default clock source depends on the chip revision on ESP32-P4. A commented-out old condition and a duplicated Japanese line under its English version are removed.Checks