Repository navigation
Header comments: setAlarmIRQ description, charge setter results - #430
Merged
Merged
Conversation
Attach alarm documentation to the callable overload and explain that failed charge requests may still have changed hardware settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header comments only (no code change):
setAlarmIRQ(int)overload, so IDEs showed it there and nothing on the overloads that can be called. It is now onsetAlarmIRQ(const rtc_date_t*, const rtc_time_t*), the other overloads refer to it, and the deleted overload keeps only its migration note.setBatteryCharge()/setChargeCurrent()/setChargeVoltage()said that false means the setting did not take effect. On some boards a step after the write can fail (e.g. PaperMono restores its I2C gate after writing the charger), so false now means the request could not be confirmed and the setting may or may not have been applied.Checked on the fork CI (all builds pass, no new warnings).