Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_to_openapi_type() updates the class-level DEFAULT_FIELD_MAPPING dictionary, so overriding a field in one MarshmallowPlugin silently changes schemas produced by other plugin instances and by instances created later. Give each OpenAPIConverter its own copy of the configured mapping.
Add a regression that customizes a String subclass in one plugin and verifies that both an existing second plugin and a newly-created third plugin retain the default String mapping.
Validation on Python 3.12.14 / marshmallow 4.3.1: the regression fails before the fix because the second plugin unexpectedly reports integer/int32. The full suite after the fix has 637 passed and 6 skipped. Ruff lint/format and git diff --check pass.