Repository navigation
abseil-cpp: define _CRT_SECURE_NO_WARNINGS like abseil's own build - #2973
Open
ContradNamiseb wants to merge 3 commits into
Open
ContradNamiseb wants to merge 3 commits into
ContradNamiseb wants to merge 3 commits into
Conversation
The port predates three sanity checks: the wrap used the name = dep provide form, meson_version was >=0.49.0 and the port was not formatted with meson format. List dependency_names in the wrap and override each name in the port, as ftxui did in dc9d1b5, require meson >=0.56.0, and format the port.
Author
|
The failing checks come from rules the abseil-cpp port predates (meson format, the |
sanity_checks.py requires a new release whenever the port's files change.
abseil's CMake and Bazel builds pass /D_CRT_SECURE_NO_WARNINGS with /DNOMINMAX on Windows (absl/copts/copts.py), but the meson port only passes /DNOMINMAX, so building on Windows warns about strcpy, strncpy and getenv.
ContradNamiseb
force-pushed
the
abseil-cpp-crt-secure-no-warnings
branch
from
October 20, 2026 07:45
fa61ca9 to
1967e69
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building abseil-cpp on Windows warns that
strcpy,strncpyandgetenvare unsafe, inabsl/strings/numbers.cc,absl/synchronization/mutex.cc,absl/debugging/symbolize_win32.incandabsl/log/flags.cc. For example, from an icx build of 20240722.0 (the same calls are still in 20250814.1):abseil's own build passes
/D_CRT_SECURE_NO_WARNINGStogether with/DNOMINMAX(absl/copts/copts.py), but the meson port only has/DNOMINMAX. This adds the define and bumps the revision to 20250814.1-3. It builds on #2974, so until that is merged this diff includes its commits.AI disclosure
This PR was made with the help of AI and was verified by me.