[Bug] autocompletion does not work inside strings #2883

Activity

1. rcjsuen commented on Jan 9, 2022

   

   Remy Suen (rcjsuen)

   on Jan 9, 2022

   Contributor

   More actions

   

   fdrag Seems fine to me. 🤔
2. fdrag commented on Jan 9, 2022

   

   fdrag

   on Jan 9, 2022

   Author

   More actions

   

   fdrag Seems fine to me. 🤔

   xBeOt1Z9GW.mp4
3. fdrag commented on Jan 9, 2022

   

   fdrag

   on Jan 9, 2022

   Last edited by fdrag

   Author

   More actions

   it still not working for me, how to implement string autocompletion myself?

   i want to copy this
   
4. rcjsuen commented on Jan 9, 2022

   

   Remy Suen (rcjsuen)

   on Jan 9, 2022

   Contributor

   More actions

   it still not working for me, how to implement string autocompletion myself?

   If you invoke Intellisense explicitly with Control+Space (or Cmd+Space on macOS) it works.

   i want to copy this

   What is this from?
5. fdrag commented on Jan 9, 2022

   

   fdrag

   on Jan 9, 2022

   Last edited by fdrag

   Author

   More actions

   it is from visual studio code, im trying to making my own monaco editor for testing purposes but im not knowing how to implement those

   how to automatic invoke intellisense when in qoutes?
6. rcjsuen commented on Jan 9, 2022

   

   Remy Suen (rcjsuen)

   on Jan 9, 2022

   Contributor

   More actions

   monaco-editor/src/typescript/languageFeatures.ts

   Lines 435 to 438 in a385674

   	export class SuggestAdapter extends Adapter implements languages.CompletionItemProvider {
   	public get triggerCharacters(): string[] {
   	return ['.'];
   	}

   1. At a surface level, the obvious issue is that the trigger characters in Visual Studio Code are not the same as Monaco's (per above). We can see Monaco does not invoke Intellisense as aggressively as VS Code.

   monaco-editor/website/typedoc/monaco.d.ts

   Lines 3056 to 3060 in a385674

   	/**
   	* Enable quick suggestions (shadow suggestions)
   	* Defaults to true.
   	*/
   	quickSuggestions?: boolean | IQuickSuggestionsOptions;

   2. Another issue is that quickSuggestions seems to be false when it supposedly defaults to being true. Turning it on explicitly seems to fix your problem. Please try the code below, fdrag.

   const content = `interface env {
   	a: "abc" | "def";
   }
   let env: env = {
   	a: ""
   }`;
   monaco.editor.create(document.getElementById('container'), {
       value: content,
       language: 'typescript',
       quickSuggestions: true
   });
7. rcjsuen commented on Jan 9, 2022

   

   Remy Suen (rcjsuen)

   on Jan 9, 2022

   Contributor

   More actions

   const defaults: ValidQuickSuggestionsOptions = {
       other: true,
       comments: false,
       strings: false
   };

   I think this is the issue. Quick suggestions are enabled by default...they're just not enabled by default if the text caret is inside a comment or a string. The comment should be updated to reflect this in my opinion.
8. fdrag commented on Jan 9, 2022

   

   fdrag

   on Jan 9, 2022

   Author

   More actions

   ValidQuickSuggestionsOptions 

   Thank you for your explanation. :D
9. Henning Dieterichs (hediet)

   added

   question

   on Jan 10, 2022
10. microsoft

    locked and limited conversation to collaborators on Mar 3, 2023
11. Henning Dieterichs (hediet)

    converted this issue into a discussion #3679 on Mar 3, 2023