Repository navigation
fix(chat): label queued actions that stop the running turn - #5333
Draft
leonongoing wants to merge 4 commits into
Draft
leonongoing wants to merge 4 commits into
leonongoing wants to merge 4 commits into
Conversation
|
@leonongoing is attempting to deploy a commit to the SupaMaus Team on Vercel. A member of the Team first needs to authorize it. |
Pre-merge checks:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an engine cannot take a queued message into its running turn, the queue action stops that turn before the queue can advance. The button used to say Steer, with the interruption disclosed only in the tooltip and accessible name. The button now says Stop and send, Stop and send next for the head of a room queue, or Stop and send all for a direct queue. Live steering keeps its current labels.
This addresses the UI wording part of #5236. The stop and queue dispatch logic is unchanged; this does not resolve the report about cancellation of work delegated to other bots.
Desktop before · Desktop after · Browser proof. Chrome rendered the real queue component with synthetic messages at 800px and 390px. The fallback labels fit both widths; this fixture does not dispatch turns.
The three new label assertions failed on the original component. All 71 Composer and size guard tests passed after the change.
pnpm lint,pnpm i18n:check, contrast and diff checks passed.Full local
pnpm typecheckhit the Node heap limit. Exact-head Linux validation passed full typecheck. Unfilteredpnpm testexited 1: 32,904 passed, 159 failed, 320 skipped and 3 todo across 2,561 files. Failures included Cloud and Bot Box fixtures. Broker, Electron and packaged-server commands passed when run separately. The 71 focused Composer tests above passed on that prior head. The run also found that the three new English labels left the Brazilian Portuguese pack incomplete.Prior head
7a8c8575badds Brazilian Portuguese and Traditional Chinese translations with their English source hashes. The i18n test reproduced the prior-head failure locally. With the translations, all 55 i18n and queued-composer tests passed, and all 16 locale catalogs validated. GitHub cancelled the current-head Linux full validation without a complete result. The PR remains a draft.Prior head
8f91b45b1merges upstreamd83c52dd3. The source-hash conflict is resolved by retaining all upstream entries and the six hashes for the new button translations. All 106 Composer and i18n tests passed across 9 files, locale validation passed for all 16 languages, and scoped lint and the diff against main passed. Full typecheck and full test have not run on this merged head.Current head
918e66550merges upstream237505ea6. The six queue-action translation hashes sit beside the existing queue labels, retaining the new upstream catalog entries. All 106 Composer and i18n tests passed across 9 files, locale validation passed for all 16 languages, and the diff against main passed. Full localpnpm typecheckpassed on this head (Node 24.19.0, 4 GiB heap). Fullpnpm testhas not run on this merged head.