Repository navigation
fix(settings): find tool calls in simple Settings search - #5373
Draft
leonongoing wants to merge 1 commit into
Draft
leonongoing wants to merge 1 commit into
leonongoing wants to merge 1 commit into
Conversation
|
@leonongoing is attempting to deploy a commit to the SupaMaus Team on Vercel. A member of the Team first needs to authorize it. |
Pre-merge checks:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Simple Settings search now offers a Tool calls result that opens Looks and scrolls directly to the existing switch. Match its translated title and accessible name; keep this server setting unavailable in a remote client.
Why
Searching for tool calls could lead only to General, where the switch is behind Browse themes. Related #5294 (the tool-call Settings search item).
How it was verified
On macOS Intel, Node 24.19.0 and pnpm 10.33:
pnpm lintandgit diff --checkpassed.tool calls, opened the result and toggled the switch. The production components use an isolated in-memory store/API fixture; this is renderer proof, not packaged Electron or live-server validation.pnpm typecheckpassed atb0dfea60673c05f995ae6d2d878959438e1ebad6; unfilteredpnpm testhas not run on this revision. This PR stays Draft while full validation is incomplete.Screenshots
Before search:
After search:
Opened switch:
Exact-revision browser receipt
Checklist
pnpm typecheckandpnpm testpass locallydist-server/editsshell: true/ cmd.exe string-building