Skip to content

fix(settings): find tool calls in simple Settings search - #5373

Draft
leonongoing wants to merge 1 commit into
milind-soni:mainfrom
leonongoing:leon/fix-settings-tool-call-search-5294
Draft

leonongoing wants to merge 1 commit into
milind-soni:mainfrom
leonongoing:leon/fix-settings-tool-call-search-5294

Conversation

@leonongoing

@leonongoing leonongoing commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Simple Settings search now offers a Tool calls result that opens Looks and scrolls directly to the existing switch. Match its translated title and accessible name; keep this server setting unavailable in a remote client.

Why

Searching for tool calls could lead only to General, where the switch is behind Browse themes. Related #5294 (the tool-call Settings search item).

How it was verified

On macOS Intel, Node 24.19.0 and pnpm 10.33:

  • Added English and Portuguese DOM regressions that fail on upstream and pass after the change. They click the result and toggle the existing switch, checking the config PATCH and updated state. Also checked the remote-client restriction.
  • The Settings key-search, Simple, groups and i18n suites: 56 tests passed in 4 files.
  • pnpm lint and git diff --check passed.
  • Real Chrome before/after at this exact source revision: searched tool calls, opened the result and toggled the switch. The production components use an isolated in-memory store/API fixture; this is renderer proof, not packaged Electron or live-server validation.
  • Full pnpm typecheck passed at b0dfea60673c05f995ae6d2d878959438e1ebad6; unfiltered pnpm test has not run on this revision. This PR stays Draft while full validation is incomplete.

Screenshots

Before search:

Before: no direct tool-call search result

After search:

After: Tool calls result opens Looks

Opened switch:

Existing tool-call switch reached and enabled

Exact-revision browser receipt

Checklist

  • pnpm typecheck and pnpm test pass locally
  • Server behavior changes come with tests (UI navigation only; existing config API unchanged)
  • No dist-server/ edits
  • macOS-only code is platform-gated; no shell: true / cmd.exe string-building
  • No secrets in logs, responses, events, or argv

@vercel

vercel Bot commented Nov 11, 2026

Copy link
Copy Markdown

@leonongoing is attempting to deploy a commit to the SupaMaus Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Inconclusive 2

Failed Failed checks: 2 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Description check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant