Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 20, 2026 07:19
aidenybai
marked this pull request as draft
October 20, 2026 07:35
aidenybai
marked this pull request as ready for review
October 20, 2026 08:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When
no-img-without-dimensionsis enabled, it can report an image whose local styled-components parent already reserves a fixed box at every visible screen width. The parent box can provide the missing layout reservation.What changed
styled.divparents with positive fixed dimensions or hidden states across all supported screen-width intervals, with both image maximum-size constraints.This covers ordinary screen rendering under the declared styled-components contract. It does not establish print coverage, arbitrary provider substitutions, or measured CLS.
Test plan
DAYTONA_API_KEYis absent; the local comparisons are finite synthetic evidence.