Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UcEMc87cTLJsvmHf6r9Mkb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the form is submitted,
testAdvancedFormwaits fordocument.getElementsByTagName("title") === "Advanced form save". That compares anHTMLCollectionwith a string, so it's never true:wait()then returnsfalse, so the posted values and the uploaded file are never checked.The condition was changed to this in 2befd23 (before that it was
!== null, which is always true). Now it'sdocument.title === "Advanced form save", which matches the<title>ofadvanced_form_post.php.Tested locally with webdriver-classic-driver on Selenium 3.141.59: the test now takes ~1.5-2s instead of ~5.8s and runs the final assertion (21 instead of 20), on both Brave (as Chrome) and Firefox.
🤖 Generated with Claude Code